1357 lines
57 KiB
C++
1357 lines
57 KiB
C++
/*
|
|
* Copyright (C) 2014 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include <string>
|
|
#include <vector>
|
|
#include <sys/param.h>
|
|
|
|
#include "android-base/strings.h"
|
|
#include <gtest/gtest.h>
|
|
|
|
#include "art_field-inl.h"
|
|
#include "class_linker-inl.h"
|
|
#include "class_loader_context.h"
|
|
#include "common_runtime_test.h"
|
|
#include "dexopt_test.h"
|
|
#include "oat_file.h"
|
|
#include "oat_file_manager.h"
|
|
#include "os.h"
|
|
#include "scoped_thread_state_change-inl.h"
|
|
#include "thread-current-inl.h"
|
|
#include "utils.h"
|
|
|
|
namespace art {
|
|
|
|
static const std::string kSpecialSharedLibrary = "&";
|
|
static ClassLoaderContext* kSpecialSharedLibraryContext = nullptr;
|
|
|
|
class OatFileAssistantTest : public DexoptTest {};
|
|
|
|
class OatFileAssistantNoDex2OatTest : public DexoptTest {
|
|
public:
|
|
virtual void SetUpRuntimeOptions(RuntimeOptions* options) {
|
|
DexoptTest::SetUpRuntimeOptions(options);
|
|
options->push_back(std::make_pair("-Xnodex2oat", nullptr));
|
|
}
|
|
};
|
|
|
|
class ScopedNonWritable {
|
|
public:
|
|
explicit ScopedNonWritable(const std::string& dex_location) {
|
|
is_valid_ = false;
|
|
size_t pos = dex_location.rfind('/');
|
|
if (pos != std::string::npos) {
|
|
is_valid_ = true;
|
|
dex_parent_ = dex_location.substr(0, pos);
|
|
if (chmod(dex_parent_.c_str(), 0555) != 0) {
|
|
PLOG(ERROR) << "Could not change permissions on " << dex_parent_;
|
|
}
|
|
}
|
|
}
|
|
|
|
bool IsSuccessful() { return is_valid_ && (access(dex_parent_.c_str(), W_OK) != 0); }
|
|
|
|
~ScopedNonWritable() {
|
|
if (is_valid_) {
|
|
if (chmod(dex_parent_.c_str(), 0777) != 0) {
|
|
PLOG(ERROR) << "Could not restore permissions on " << dex_parent_;
|
|
}
|
|
}
|
|
}
|
|
|
|
private:
|
|
std::string dex_parent_;
|
|
bool is_valid_;
|
|
};
|
|
|
|
static bool IsExecutedAsRoot() {
|
|
return geteuid() == 0;
|
|
}
|
|
|
|
// Case: We have a DEX file, but no OAT file for it.
|
|
// Expect: The status is kDex2OatNeeded.
|
|
TEST_F(OatFileAssistantTest, DexNoOat) {
|
|
std::string dex_location = GetScratchDir() + "/DexNoOat.jar";
|
|
Copy(GetDexSrc1(), dex_location);
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatFromScratch,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kExtract));
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatFromScratch,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kQuicken));
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatFromScratch,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeedProfile));
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatFromScratch,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
|
|
EXPECT_FALSE(oat_file_assistant.IsInBootClassPath());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OdexFileStatus());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OatFileStatus());
|
|
EXPECT_TRUE(oat_file_assistant.HasOriginalDexFiles());
|
|
}
|
|
|
|
// Case: We have no DEX file and no OAT file.
|
|
// Expect: Status is kNoDexOptNeeded. Loading should fail, but not crash.
|
|
TEST_F(OatFileAssistantTest, NoDexNoOat) {
|
|
std::string dex_location = GetScratchDir() + "/NoDexNoOat.jar";
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, true);
|
|
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
EXPECT_FALSE(oat_file_assistant.HasOriginalDexFiles());
|
|
|
|
// Trying to make the oat file up to date should not fail or crash.
|
|
std::string error_msg;
|
|
EXPECT_EQ(OatFileAssistant::kUpdateSucceeded,
|
|
oat_file_assistant.MakeUpToDate(false, kSpecialSharedLibraryContext, &error_msg));
|
|
|
|
// Trying to get the best oat file should fail, but not crash.
|
|
std::unique_ptr<OatFile> oat_file = oat_file_assistant.GetBestOatFile();
|
|
EXPECT_EQ(nullptr, oat_file.get());
|
|
}
|
|
|
|
// Case: We have a DEX file and a PIC ODEX file, but no OAT file.
|
|
// Expect: The status is kNoDexOptNeeded, because PIC needs no relocation.
|
|
TEST_F(OatFileAssistantTest, OdexUpToDate) {
|
|
std::string dex_location = GetScratchDir() + "/OdexUpToDate.jar";
|
|
std::string odex_location = GetOdexDir() + "/OdexUpToDate.odex";
|
|
Copy(GetDexSrc1(), dex_location);
|
|
GeneratePicOdexForTest(dex_location, odex_location, CompilerFilter::kSpeed);
|
|
|
|
// For the use of oat location by making the dex parent not writable.
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
|
|
EXPECT_EQ(-OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
EXPECT_EQ(-OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kQuicken));
|
|
EXPECT_EQ(-OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kExtract));
|
|
EXPECT_EQ(-OatFileAssistant::kDex2OatForFilter,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kEverything));
|
|
|
|
EXPECT_FALSE(oat_file_assistant.IsInBootClassPath());
|
|
EXPECT_EQ(OatFileAssistant::kOatUpToDate, oat_file_assistant.OdexFileStatus());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OatFileStatus());
|
|
EXPECT_TRUE(oat_file_assistant.HasOriginalDexFiles());
|
|
}
|
|
|
|
// Case: We have a DEX file and a PIC ODEX file, but no OAT file. We load the dex
|
|
// file via a symlink.
|
|
// Expect: The status is kNoDexOptNeeded, because PIC needs no relocation.
|
|
TEST_F(OatFileAssistantTest, OdexUpToDateSymLink) {
|
|
std::string scratch_dir = GetScratchDir();
|
|
std::string dex_location = GetScratchDir() + "/OdexUpToDate.jar";
|
|
std::string odex_location = GetOdexDir() + "/OdexUpToDate.odex";
|
|
|
|
Copy(GetDexSrc1(), dex_location);
|
|
GeneratePicOdexForTest(dex_location, odex_location, CompilerFilter::kSpeed);
|
|
|
|
// Now replace the dex location with a symlink.
|
|
std::string link = scratch_dir + "/link";
|
|
ASSERT_EQ(0, symlink(scratch_dir.c_str(), link.c_str()));
|
|
dex_location = link + "/OdexUpToDate.jar";
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
|
|
EXPECT_EQ(-OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
EXPECT_EQ(-OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kQuicken));
|
|
EXPECT_EQ(-OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kExtract));
|
|
EXPECT_EQ(-OatFileAssistant::kDex2OatForFilter,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kEverything));
|
|
|
|
EXPECT_FALSE(oat_file_assistant.IsInBootClassPath());
|
|
EXPECT_EQ(OatFileAssistant::kOatUpToDate, oat_file_assistant.OdexFileStatus());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OatFileStatus());
|
|
EXPECT_TRUE(oat_file_assistant.HasOriginalDexFiles());
|
|
}
|
|
|
|
// Case: We have a DEX file and up-to-date OAT file for it.
|
|
// Expect: The status is kNoDexOptNeeded.
|
|
TEST_F(OatFileAssistantTest, OatUpToDate) {
|
|
if (IsExecutedAsRoot()) {
|
|
// We cannot simulate non writable locations when executed as root: b/38000545.
|
|
LOG(ERROR) << "Test skipped because it's running as root";
|
|
return;
|
|
}
|
|
|
|
std::string dex_location = GetScratchDir() + "/OatUpToDate.jar";
|
|
Copy(GetDexSrc1(), dex_location);
|
|
GenerateOatForTest(dex_location.c_str(), CompilerFilter::kSpeed);
|
|
|
|
// For the use of oat location by making the dex parent not writable.
|
|
ScopedNonWritable scoped_non_writable(dex_location);
|
|
ASSERT_TRUE(scoped_non_writable.IsSuccessful());
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kQuicken));
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kExtract));
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatForFilter,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kEverything));
|
|
|
|
EXPECT_FALSE(oat_file_assistant.IsInBootClassPath());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OdexFileStatus());
|
|
EXPECT_EQ(OatFileAssistant::kOatUpToDate, oat_file_assistant.OatFileStatus());
|
|
EXPECT_TRUE(oat_file_assistant.HasOriginalDexFiles());
|
|
}
|
|
|
|
// Case: We have a DEX file and up-to-date OAT file for it. We load the dex file
|
|
// via a symlink.
|
|
// Expect: The status is kNoDexOptNeeded.
|
|
TEST_F(OatFileAssistantTest, OatUpToDateSymLink) {
|
|
if (IsExecutedAsRoot()) {
|
|
// We cannot simulate non writable locations when executed as root: b/38000545.
|
|
LOG(ERROR) << "Test skipped because it's running as root";
|
|
return;
|
|
}
|
|
|
|
std::string real = GetScratchDir() + "/real";
|
|
ASSERT_EQ(0, mkdir(real.c_str(), 0700));
|
|
std::string link = GetScratchDir() + "/link";
|
|
ASSERT_EQ(0, symlink(real.c_str(), link.c_str()));
|
|
|
|
std::string dex_location = real + "/OatUpToDate.jar";
|
|
|
|
Copy(GetDexSrc1(), dex_location);
|
|
GenerateOatForTest(dex_location.c_str(), CompilerFilter::kSpeed);
|
|
|
|
// Update the dex location to point to the symlink.
|
|
dex_location = link + "/OatUpToDate.jar";
|
|
|
|
// For the use of oat location by making the dex parent not writable.
|
|
ScopedNonWritable scoped_non_writable(dex_location);
|
|
ASSERT_TRUE(scoped_non_writable.IsSuccessful());
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kQuicken));
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kExtract));
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatForFilter,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kEverything));
|
|
|
|
EXPECT_FALSE(oat_file_assistant.IsInBootClassPath());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OdexFileStatus());
|
|
EXPECT_EQ(OatFileAssistant::kOatUpToDate, oat_file_assistant.OatFileStatus());
|
|
EXPECT_TRUE(oat_file_assistant.HasOriginalDexFiles());
|
|
}
|
|
|
|
// Case: We have a DEX file and up-to-date (ODEX) VDEX file for it, but no
|
|
// ODEX file.
|
|
TEST_F(OatFileAssistantTest, VdexUpToDateNoOdex) {
|
|
// This test case is only meaningful if vdex is enabled.
|
|
if (!kIsVdexEnabled) {
|
|
return;
|
|
}
|
|
|
|
std::string dex_location = GetScratchDir() + "/VdexUpToDateNoOdex.jar";
|
|
std::string odex_location = GetOdexDir() + "/VdexUpToDateNoOdex.oat";
|
|
|
|
Copy(GetDexSrc1(), dex_location);
|
|
|
|
// Generating and deleting the oat file should have the side effect of
|
|
// creating an up-to-date vdex file.
|
|
GenerateOdexForTest(dex_location, odex_location, CompilerFilter::kSpeed);
|
|
ASSERT_EQ(0, unlink(odex_location.c_str()));
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
|
|
// Even though the vdex file is up to date, because we don't have the oat
|
|
// file, we can't know that the vdex depends on the boot image and is up to
|
|
// date with respect to the boot image. Instead we must assume the vdex file
|
|
// depends on the boot image and is out of date with respect to the boot
|
|
// image.
|
|
EXPECT_EQ(-OatFileAssistant::kDex2OatForBootImage,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
|
|
// Make sure we don't crash in this case when we dump the status. We don't
|
|
// care what the actual dumped value is.
|
|
oat_file_assistant.GetStatusDump();
|
|
}
|
|
|
|
// Case: We have a DEX file and empty VDEX and ODEX files.
|
|
TEST_F(OatFileAssistantTest, EmptyVdexOdex) {
|
|
std::string dex_location = GetScratchDir() + "/EmptyVdexOdex.jar";
|
|
std::string odex_location = GetOdexDir() + "/EmptyVdexOdex.oat";
|
|
std::string vdex_location = GetOdexDir() + "/EmptyVdexOdex.vdex";
|
|
|
|
Copy(GetDexSrc1(), dex_location);
|
|
ScratchFile vdex_file(vdex_location.c_str());
|
|
ScratchFile odex_file(odex_location.c_str());
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatFromScratch,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
}
|
|
|
|
// Case: We have a DEX file and up-to-date (OAT) VDEX file for it, but no OAT
|
|
// file.
|
|
TEST_F(OatFileAssistantTest, VdexUpToDateNoOat) {
|
|
// This test case is only meaningful if vdex is enabled.
|
|
if (!kIsVdexEnabled) {
|
|
return;
|
|
}
|
|
if (IsExecutedAsRoot()) {
|
|
// We cannot simulate non writable locations when executed as root: b/38000545.
|
|
LOG(ERROR) << "Test skipped because it's running as root";
|
|
return;
|
|
}
|
|
|
|
std::string dex_location = GetScratchDir() + "/VdexUpToDateNoOat.jar";
|
|
std::string oat_location;
|
|
std::string error_msg;
|
|
ASSERT_TRUE(OatFileAssistant::DexLocationToOatFilename(
|
|
dex_location, kRuntimeISA, &oat_location, &error_msg)) << error_msg;
|
|
|
|
Copy(GetDexSrc1(), dex_location);
|
|
GenerateOatForTest(dex_location.c_str(), CompilerFilter::kSpeed);
|
|
ASSERT_EQ(0, unlink(oat_location.c_str()));
|
|
|
|
ScopedNonWritable scoped_non_writable(dex_location);
|
|
ASSERT_TRUE(scoped_non_writable.IsSuccessful());
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
|
|
// Even though the vdex file is up to date, because we don't have the oat
|
|
// file, we can't know that the vdex depends on the boot image and is up to
|
|
// date with respect to the boot image. Instead we must assume the vdex file
|
|
// depends on the boot image and is out of date with respect to the boot
|
|
// image.
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatForBootImage,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
}
|
|
|
|
// Case: We have a DEX file and speed-profile OAT file for it.
|
|
// Expect: The status is kNoDexOptNeeded if the profile hasn't changed, but
|
|
// kDex2Oat if the profile has changed.
|
|
TEST_F(OatFileAssistantTest, ProfileOatUpToDate) {
|
|
if (IsExecutedAsRoot()) {
|
|
// We cannot simulate non writable locations when executed as root: b/38000545.
|
|
LOG(ERROR) << "Test skipped because it's running as root";
|
|
return;
|
|
}
|
|
|
|
std::string dex_location = GetScratchDir() + "/ProfileOatUpToDate.jar";
|
|
Copy(GetDexSrc1(), dex_location);
|
|
GenerateOatForTest(dex_location.c_str(), CompilerFilter::kSpeedProfile);
|
|
|
|
ScopedNonWritable scoped_non_writable(dex_location);
|
|
ASSERT_TRUE(scoped_non_writable.IsSuccessful());
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeedProfile, false));
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kQuicken, false));
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatForFilter,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeedProfile, true));
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatForFilter,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kQuicken, true));
|
|
|
|
EXPECT_FALSE(oat_file_assistant.IsInBootClassPath());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OdexFileStatus());
|
|
EXPECT_EQ(OatFileAssistant::kOatUpToDate, oat_file_assistant.OatFileStatus());
|
|
EXPECT_TRUE(oat_file_assistant.HasOriginalDexFiles());
|
|
}
|
|
|
|
// Case: We have a MultiDEX file and up-to-date OAT file for it.
|
|
// Expect: The status is kNoDexOptNeeded and we load all dex files.
|
|
TEST_F(OatFileAssistantTest, MultiDexOatUpToDate) {
|
|
if (IsExecutedAsRoot()) {
|
|
// We cannot simulate non writable locations when executed as root: b/38000545.
|
|
LOG(ERROR) << "Test skipped because it's running as root";
|
|
return;
|
|
}
|
|
|
|
std::string dex_location = GetScratchDir() + "/MultiDexOatUpToDate.jar";
|
|
Copy(GetMultiDexSrc1(), dex_location);
|
|
GenerateOatForTest(dex_location.c_str(), CompilerFilter::kSpeed);
|
|
|
|
ScopedNonWritable scoped_non_writable(dex_location);
|
|
ASSERT_TRUE(scoped_non_writable.IsSuccessful());
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, true);
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed, false));
|
|
EXPECT_TRUE(oat_file_assistant.HasOriginalDexFiles());
|
|
|
|
// Verify we can load both dex files.
|
|
std::unique_ptr<OatFile> oat_file = oat_file_assistant.GetBestOatFile();
|
|
ASSERT_TRUE(oat_file.get() != nullptr);
|
|
EXPECT_TRUE(oat_file->IsExecutable());
|
|
std::vector<std::unique_ptr<const DexFile>> dex_files;
|
|
dex_files = oat_file_assistant.LoadDexFiles(*oat_file, dex_location.c_str());
|
|
EXPECT_EQ(2u, dex_files.size());
|
|
}
|
|
|
|
// Case: We have a MultiDEX file where the non-main multdex entry is out of date.
|
|
// Expect: The status is kDex2OatNeeded.
|
|
TEST_F(OatFileAssistantTest, MultiDexNonMainOutOfDate) {
|
|
if (IsExecutedAsRoot()) {
|
|
// We cannot simulate non writable locations when executed as root: b/38000545.
|
|
LOG(ERROR) << "Test skipped because it's running as root";
|
|
return;
|
|
}
|
|
|
|
std::string dex_location = GetScratchDir() + "/MultiDexNonMainOutOfDate.jar";
|
|
|
|
// Compile code for GetMultiDexSrc1.
|
|
Copy(GetMultiDexSrc1(), dex_location);
|
|
GenerateOatForTest(dex_location.c_str(), CompilerFilter::kSpeed);
|
|
|
|
// Now overwrite the dex file with GetMultiDexSrc2 so the non-main checksum
|
|
// is out of date.
|
|
Copy(GetMultiDexSrc2(), dex_location);
|
|
|
|
ScopedNonWritable scoped_non_writable(dex_location);
|
|
ASSERT_TRUE(scoped_non_writable.IsSuccessful());
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, true);
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatFromScratch,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed, false));
|
|
EXPECT_TRUE(oat_file_assistant.HasOriginalDexFiles());
|
|
}
|
|
|
|
// Case: We have a stripped MultiDEX file where the non-main multidex entry is
|
|
// out of date with respect to the odex file.
|
|
TEST_F(OatFileAssistantTest, StrippedMultiDexNonMainOutOfDate) {
|
|
std::string dex_location = GetScratchDir() + "/StrippedMultiDexNonMainOutOfDate.jar";
|
|
std::string odex_location = GetOdexDir() + "/StrippedMultiDexNonMainOutOfDate.odex";
|
|
|
|
// Compile the oat from GetMultiDexSrc1.
|
|
Copy(GetMultiDexSrc1(), dex_location);
|
|
GenerateOatForTest(dex_location.c_str(), CompilerFilter::kSpeed);
|
|
|
|
// Compile the odex from GetMultiDexSrc2, which has a different non-main
|
|
// dex checksum.
|
|
Copy(GetMultiDexSrc2(), dex_location);
|
|
GenerateOdexForTest(dex_location, odex_location, CompilerFilter::kQuicken);
|
|
|
|
// Strip the dex file.
|
|
Copy(GetStrippedDexSrc1(), dex_location);
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, /*load_executable*/false);
|
|
|
|
// Because the dex file is stripped, the odex file is considered the source
|
|
// of truth for the dex checksums. The oat file should be considered
|
|
// unusable.
|
|
std::unique_ptr<OatFile> best_file = oat_file_assistant.GetBestOatFile();
|
|
ASSERT_TRUE(best_file.get() != nullptr);
|
|
EXPECT_EQ(best_file->GetLocation(), odex_location);
|
|
EXPECT_FALSE(oat_file_assistant.HasOriginalDexFiles());
|
|
EXPECT_EQ(OatFileAssistant::kOatUpToDate, oat_file_assistant.OdexFileStatus());
|
|
EXPECT_EQ(OatFileAssistant::kOatDexOutOfDate, oat_file_assistant.OatFileStatus());
|
|
}
|
|
|
|
// Case: We have a MultiDEX file and up-to-date ODEX file for it with relative
|
|
// encoded dex locations.
|
|
// Expect: The oat file status is kNoDexOptNeeded.
|
|
TEST_F(OatFileAssistantTest, RelativeEncodedDexLocation) {
|
|
std::string dex_location = GetScratchDir() + "/RelativeEncodedDexLocation.jar";
|
|
std::string odex_location = GetOdexDir() + "/RelativeEncodedDexLocation.odex";
|
|
|
|
// Create the dex file
|
|
Copy(GetMultiDexSrc1(), dex_location);
|
|
|
|
// Create the oat file with relative encoded dex location.
|
|
std::vector<std::string> args;
|
|
args.push_back("--dex-file=" + dex_location);
|
|
args.push_back("--dex-location=" + std::string("RelativeEncodedDexLocation.jar"));
|
|
args.push_back("--oat-file=" + odex_location);
|
|
args.push_back("--compiler-filter=speed");
|
|
|
|
std::string error_msg;
|
|
ASSERT_TRUE(OatFileAssistant::Dex2Oat(args, &error_msg)) << error_msg;
|
|
|
|
// Verify we can load both dex files.
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, true);
|
|
|
|
std::unique_ptr<OatFile> oat_file = oat_file_assistant.GetBestOatFile();
|
|
ASSERT_TRUE(oat_file.get() != nullptr);
|
|
EXPECT_TRUE(oat_file->IsExecutable());
|
|
std::vector<std::unique_ptr<const DexFile>> dex_files;
|
|
dex_files = oat_file_assistant.LoadDexFiles(*oat_file, dex_location.c_str());
|
|
EXPECT_EQ(2u, dex_files.size());
|
|
}
|
|
|
|
// Case: We have a DEX file and an OAT file out of date with respect to the
|
|
// dex checksum.
|
|
TEST_F(OatFileAssistantTest, OatDexOutOfDate) {
|
|
if (IsExecutedAsRoot()) {
|
|
// We cannot simulate non writable locations when executed as root: b/38000545.
|
|
LOG(ERROR) << "Test skipped because it's running as root";
|
|
return;
|
|
}
|
|
|
|
std::string dex_location = GetScratchDir() + "/OatDexOutOfDate.jar";
|
|
|
|
// We create a dex, generate an oat for it, then overwrite the dex with a
|
|
// different dex to make the oat out of date.
|
|
Copy(GetDexSrc1(), dex_location);
|
|
GenerateOatForTest(dex_location.c_str(), CompilerFilter::kSpeed);
|
|
Copy(GetDexSrc2(), dex_location);
|
|
|
|
ScopedNonWritable scoped_non_writable(dex_location);
|
|
ASSERT_TRUE(scoped_non_writable.IsSuccessful());
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatFromScratch,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kExtract));
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatFromScratch,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
|
|
EXPECT_FALSE(oat_file_assistant.IsInBootClassPath());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OdexFileStatus());
|
|
EXPECT_EQ(OatFileAssistant::kOatDexOutOfDate, oat_file_assistant.OatFileStatus());
|
|
EXPECT_TRUE(oat_file_assistant.HasOriginalDexFiles());
|
|
}
|
|
|
|
// Case: We have a DEX file and an (ODEX) VDEX file out of date with respect
|
|
// to the dex checksum, but no ODEX file.
|
|
TEST_F(OatFileAssistantTest, VdexDexOutOfDate) {
|
|
// This test case is only meaningful if vdex is enabled.
|
|
if (!kIsVdexEnabled) {
|
|
return;
|
|
}
|
|
|
|
std::string dex_location = GetScratchDir() + "/VdexDexOutOfDate.jar";
|
|
std::string odex_location = GetOdexDir() + "/VdexDexOutOfDate.oat";
|
|
|
|
Copy(GetDexSrc1(), dex_location);
|
|
GenerateOdexForTest(dex_location, odex_location, CompilerFilter::kSpeed);
|
|
ASSERT_EQ(0, unlink(odex_location.c_str()));
|
|
Copy(GetDexSrc2(), dex_location);
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatFromScratch,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
}
|
|
|
|
// Case: We have a MultiDEX (ODEX) VDEX file where the non-main multidex entry
|
|
// is out of date and there is no corresponding ODEX file.
|
|
TEST_F(OatFileAssistantTest, VdexMultiDexNonMainOutOfDate) {
|
|
// This test case is only meaningful if vdex is enabled.
|
|
if (!kIsVdexEnabled) {
|
|
return;
|
|
}
|
|
|
|
std::string dex_location = GetScratchDir() + "/VdexMultiDexNonMainOutOfDate.jar";
|
|
std::string odex_location = GetOdexDir() + "/VdexMultiDexNonMainOutOfDate.odex";
|
|
|
|
Copy(GetMultiDexSrc1(), dex_location);
|
|
GenerateOdexForTest(dex_location, odex_location, CompilerFilter::kSpeed);
|
|
ASSERT_EQ(0, unlink(odex_location.c_str()));
|
|
Copy(GetMultiDexSrc2(), dex_location);
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatFromScratch,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
}
|
|
|
|
// Case: We have a DEX file and an OAT file out of date with respect to the
|
|
// boot image.
|
|
TEST_F(OatFileAssistantTest, OatImageOutOfDate) {
|
|
if (IsExecutedAsRoot()) {
|
|
// We cannot simulate non writable locations when executed as root: b/38000545.
|
|
LOG(ERROR) << "Test skipped because it's running as root";
|
|
return;
|
|
}
|
|
|
|
std::string dex_location = GetScratchDir() + "/OatImageOutOfDate.jar";
|
|
|
|
Copy(GetDexSrc1(), dex_location);
|
|
GenerateOatForTest(dex_location.c_str(),
|
|
CompilerFilter::kSpeed,
|
|
/*relocate*/true,
|
|
/*pic*/false,
|
|
/*with_alternate_image*/true);
|
|
|
|
ScopedNonWritable scoped_non_writable(dex_location);
|
|
ASSERT_TRUE(scoped_non_writable.IsSuccessful());
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatForBootImage,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kExtract));
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatForBootImage,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kQuicken));
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatForBootImage,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
|
|
EXPECT_FALSE(oat_file_assistant.IsInBootClassPath());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OdexFileStatus());
|
|
EXPECT_EQ(OatFileAssistant::kOatBootImageOutOfDate, oat_file_assistant.OatFileStatus());
|
|
EXPECT_TRUE(oat_file_assistant.HasOriginalDexFiles());
|
|
}
|
|
|
|
// Case: We have a DEX file and a verify-at-runtime OAT file out of date with
|
|
// respect to the boot image.
|
|
// It shouldn't matter that the OAT file is out of date, because it is
|
|
// verify-at-runtime.
|
|
TEST_F(OatFileAssistantTest, OatVerifyAtRuntimeImageOutOfDate) {
|
|
if (IsExecutedAsRoot()) {
|
|
// We cannot simulate non writable locations when executed as root: b/38000545.
|
|
LOG(ERROR) << "Test skipped because it's running as root";
|
|
return;
|
|
}
|
|
|
|
std::string dex_location = GetScratchDir() + "/OatVerifyAtRuntimeImageOutOfDate.jar";
|
|
|
|
Copy(GetDexSrc1(), dex_location);
|
|
GenerateOatForTest(dex_location.c_str(),
|
|
CompilerFilter::kExtract,
|
|
/*relocate*/true,
|
|
/*pic*/false,
|
|
/*with_alternate_image*/true);
|
|
|
|
ScopedNonWritable scoped_non_writable(dex_location);
|
|
ASSERT_TRUE(scoped_non_writable.IsSuccessful());
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kExtract));
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatForFilter,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kQuicken));
|
|
|
|
EXPECT_FALSE(oat_file_assistant.IsInBootClassPath());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OdexFileStatus());
|
|
EXPECT_EQ(OatFileAssistant::kOatUpToDate, oat_file_assistant.OatFileStatus());
|
|
EXPECT_TRUE(oat_file_assistant.HasOriginalDexFiles());
|
|
}
|
|
|
|
// Case: We have a DEX file and an ODEX file, but no OAT file.
|
|
TEST_F(OatFileAssistantTest, DexOdexNoOat) {
|
|
std::string dex_location = GetScratchDir() + "/DexOdexNoOat.jar";
|
|
std::string odex_location = GetOdexDir() + "/DexOdexNoOat.odex";
|
|
|
|
// Create the dex and odex files
|
|
Copy(GetDexSrc1(), dex_location);
|
|
GenerateOdexForTest(dex_location, odex_location, CompilerFilter::kSpeed);
|
|
|
|
// Verify the status.
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kExtract));
|
|
EXPECT_EQ(-OatFileAssistant::kDex2OatForRelocation,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
|
|
EXPECT_FALSE(oat_file_assistant.IsInBootClassPath());
|
|
EXPECT_EQ(OatFileAssistant::kOatRelocationOutOfDate, oat_file_assistant.OdexFileStatus());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OatFileStatus());
|
|
EXPECT_TRUE(oat_file_assistant.HasOriginalDexFiles());
|
|
|
|
// We should still be able to get the non-executable odex file to run from.
|
|
std::unique_ptr<OatFile> oat_file = oat_file_assistant.GetBestOatFile();
|
|
ASSERT_TRUE(oat_file.get() != nullptr);
|
|
}
|
|
|
|
// Case: We have a stripped DEX file and a PIC ODEX file, but no OAT file.
|
|
TEST_F(OatFileAssistantTest, StrippedDexOdexNoOat) {
|
|
std::string dex_location = GetScratchDir() + "/StrippedDexOdexNoOat.jar";
|
|
std::string odex_location = GetOdexDir() + "/StrippedDexOdexNoOat.odex";
|
|
|
|
// Create the dex and odex files
|
|
Copy(GetDexSrc1(), dex_location);
|
|
GeneratePicOdexForTest(dex_location, odex_location, CompilerFilter::kSpeed);
|
|
|
|
// Strip the dex file
|
|
Copy(GetStrippedDexSrc1(), dex_location);
|
|
|
|
// Verify the status.
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, true);
|
|
|
|
EXPECT_EQ(-OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
|
|
EXPECT_FALSE(oat_file_assistant.IsInBootClassPath());
|
|
EXPECT_EQ(OatFileAssistant::kOatUpToDate, oat_file_assistant.OdexFileStatus());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OatFileStatus());
|
|
EXPECT_FALSE(oat_file_assistant.HasOriginalDexFiles());
|
|
|
|
// Verify we can load the dex files from it.
|
|
std::unique_ptr<OatFile> oat_file = oat_file_assistant.GetBestOatFile();
|
|
ASSERT_TRUE(oat_file.get() != nullptr);
|
|
EXPECT_TRUE(oat_file->IsExecutable());
|
|
std::vector<std::unique_ptr<const DexFile>> dex_files;
|
|
dex_files = oat_file_assistant.LoadDexFiles(*oat_file, dex_location.c_str());
|
|
EXPECT_EQ(1u, dex_files.size());
|
|
}
|
|
|
|
// Case: We have a stripped DEX file, a PIC ODEX file, and an out-of-date OAT file.
|
|
TEST_F(OatFileAssistantTest, StrippedDexOdexOat) {
|
|
std::string dex_location = GetScratchDir() + "/StrippedDexOdexOat.jar";
|
|
std::string odex_location = GetOdexDir() + "/StrippedDexOdexOat.odex";
|
|
|
|
// Create the oat file from a different dex file so it looks out of date.
|
|
Copy(GetDexSrc2(), dex_location);
|
|
GenerateOatForTest(dex_location.c_str(), CompilerFilter::kSpeed);
|
|
|
|
// Create the odex file
|
|
Copy(GetDexSrc1(), dex_location);
|
|
GeneratePicOdexForTest(dex_location, odex_location, CompilerFilter::kSpeed);
|
|
|
|
// Strip the dex file.
|
|
Copy(GetStrippedDexSrc1(), dex_location);
|
|
|
|
// Verify the status.
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, true);
|
|
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kExtract));
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
EXPECT_EQ(-OatFileAssistant::kDex2OatForFilter, // Compiling from the .vdex file
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kEverything));
|
|
|
|
EXPECT_FALSE(oat_file_assistant.IsInBootClassPath());
|
|
EXPECT_EQ(OatFileAssistant::kOatUpToDate, oat_file_assistant.OdexFileStatus());
|
|
EXPECT_EQ(OatFileAssistant::kOatDexOutOfDate, oat_file_assistant.OatFileStatus());
|
|
EXPECT_FALSE(oat_file_assistant.HasOriginalDexFiles());
|
|
|
|
// Verify we can load the dex files from it.
|
|
std::unique_ptr<OatFile> oat_file = oat_file_assistant.GetBestOatFile();
|
|
ASSERT_TRUE(oat_file.get() != nullptr);
|
|
EXPECT_TRUE(oat_file->IsExecutable());
|
|
std::vector<std::unique_ptr<const DexFile>> dex_files;
|
|
dex_files = oat_file_assistant.LoadDexFiles(*oat_file, dex_location.c_str());
|
|
EXPECT_EQ(1u, dex_files.size());
|
|
}
|
|
|
|
// Case: We have a stripped (or resource-only) DEX file, no ODEX file and no
|
|
// OAT file. Expect: The status is kNoDexOptNeeded.
|
|
TEST_F(OatFileAssistantTest, ResourceOnlyDex) {
|
|
std::string dex_location = GetScratchDir() + "/ResourceOnlyDex.jar";
|
|
|
|
Copy(GetStrippedDexSrc1(), dex_location);
|
|
|
|
// Verify the status.
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, true);
|
|
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kExtract));
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kQuicken));
|
|
|
|
EXPECT_FALSE(oat_file_assistant.IsInBootClassPath());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OdexFileStatus());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OatFileStatus());
|
|
EXPECT_FALSE(oat_file_assistant.HasOriginalDexFiles());
|
|
|
|
// Make the oat file up to date. This should have no effect.
|
|
std::string error_msg;
|
|
Runtime::Current()->AddCompilerOption("--compiler-filter=speed");
|
|
EXPECT_EQ(OatFileAssistant::kUpdateSucceeded,
|
|
oat_file_assistant.MakeUpToDate(false, kSpecialSharedLibraryContext, &error_msg)) <<
|
|
error_msg;
|
|
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
|
|
EXPECT_FALSE(oat_file_assistant.IsInBootClassPath());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OdexFileStatus());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OatFileStatus());
|
|
EXPECT_FALSE(oat_file_assistant.HasOriginalDexFiles());
|
|
}
|
|
|
|
// Case: We have a DEX file, an ODEX file and an OAT file, where the ODEX and
|
|
// OAT files both have patch delta of 0.
|
|
// Expect: It shouldn't crash.
|
|
TEST_F(OatFileAssistantTest, OdexOatOverlap) {
|
|
std::string dex_location = GetScratchDir() + "/OdexOatOverlap.jar";
|
|
std::string odex_location = GetOdexDir() + "/OdexOatOverlap.odex";
|
|
|
|
// Create the dex, the odex and the oat files.
|
|
Copy(GetDexSrc1(), dex_location);
|
|
GenerateOdexForTest(dex_location, odex_location, CompilerFilter::kSpeed);
|
|
GenerateOatForTest(dex_location.c_str(),
|
|
CompilerFilter::kSpeed,
|
|
/*relocate*/false,
|
|
/*pic*/false,
|
|
/*with_alternate_image*/false);
|
|
|
|
// Verify things don't go bad.
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, true);
|
|
|
|
// -kDex2OatForRelocation is expected rather than kDex2OatForRelocation
|
|
// based on the assumption that the odex location is more up-to-date than the oat
|
|
// location, even if they both need relocation.
|
|
EXPECT_EQ(-OatFileAssistant::kDex2OatForRelocation,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
|
|
EXPECT_FALSE(oat_file_assistant.IsInBootClassPath());
|
|
EXPECT_EQ(OatFileAssistant::kOatRelocationOutOfDate, oat_file_assistant.OdexFileStatus());
|
|
EXPECT_EQ(OatFileAssistant::kOatRelocationOutOfDate, oat_file_assistant.OatFileStatus());
|
|
EXPECT_TRUE(oat_file_assistant.HasOriginalDexFiles());
|
|
|
|
// Things aren't relocated, so it should fall back to interpreted.
|
|
std::unique_ptr<OatFile> oat_file = oat_file_assistant.GetBestOatFile();
|
|
ASSERT_TRUE(oat_file.get() != nullptr);
|
|
|
|
EXPECT_FALSE(oat_file->IsExecutable());
|
|
std::vector<std::unique_ptr<const DexFile>> dex_files;
|
|
dex_files = oat_file_assistant.LoadDexFiles(*oat_file, dex_location.c_str());
|
|
EXPECT_EQ(1u, dex_files.size());
|
|
}
|
|
|
|
// Case: We have a DEX file and a VerifyAtRuntime ODEX file, but no OAT file.
|
|
// Expect: The status is kNoDexOptNeeded, because VerifyAtRuntime contains no code.
|
|
TEST_F(OatFileAssistantTest, DexVerifyAtRuntimeOdexNoOat) {
|
|
std::string dex_location = GetScratchDir() + "/DexVerifyAtRuntimeOdexNoOat.jar";
|
|
std::string odex_location = GetOdexDir() + "/DexVerifyAtRuntimeOdexNoOat.odex";
|
|
|
|
// Create the dex and odex files
|
|
Copy(GetDexSrc1(), dex_location);
|
|
GenerateOdexForTest(dex_location, odex_location, CompilerFilter::kExtract);
|
|
|
|
// Verify the status.
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kExtract));
|
|
EXPECT_EQ(-OatFileAssistant::kDex2OatForFilter,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
|
|
EXPECT_FALSE(oat_file_assistant.IsInBootClassPath());
|
|
EXPECT_EQ(OatFileAssistant::kOatUpToDate, oat_file_assistant.OdexFileStatus());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OatFileStatus());
|
|
EXPECT_TRUE(oat_file_assistant.HasOriginalDexFiles());
|
|
}
|
|
|
|
// Case: We have a DEX file and up-to-date OAT file for it.
|
|
// Expect: We should load an executable dex file.
|
|
TEST_F(OatFileAssistantTest, LoadOatUpToDate) {
|
|
if (IsExecutedAsRoot()) {
|
|
// We cannot simulate non writable locations when executed as root: b/38000545.
|
|
LOG(ERROR) << "Test skipped because it's running as root";
|
|
return;
|
|
}
|
|
|
|
std::string dex_location = GetScratchDir() + "/LoadOatUpToDate.jar";
|
|
|
|
Copy(GetDexSrc1(), dex_location);
|
|
GenerateOatForTest(dex_location.c_str(), CompilerFilter::kSpeed);
|
|
|
|
ScopedNonWritable scoped_non_writable(dex_location);
|
|
ASSERT_TRUE(scoped_non_writable.IsSuccessful());
|
|
|
|
// Load the oat using an oat file assistant.
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, true);
|
|
|
|
std::unique_ptr<OatFile> oat_file = oat_file_assistant.GetBestOatFile();
|
|
ASSERT_TRUE(oat_file.get() != nullptr);
|
|
EXPECT_TRUE(oat_file->IsExecutable());
|
|
std::vector<std::unique_ptr<const DexFile>> dex_files;
|
|
dex_files = oat_file_assistant.LoadDexFiles(*oat_file, dex_location.c_str());
|
|
EXPECT_EQ(1u, dex_files.size());
|
|
}
|
|
|
|
// Case: We have a DEX file and up-to-date quicken OAT file for it.
|
|
// Expect: We should still load the oat file as executable.
|
|
TEST_F(OatFileAssistantTest, LoadExecInterpretOnlyOatUpToDate) {
|
|
if (IsExecutedAsRoot()) {
|
|
// We cannot simulate non writable locations when executed as root: b/38000545.
|
|
LOG(ERROR) << "Test skipped because it's running as root";
|
|
return;
|
|
}
|
|
|
|
std::string dex_location = GetScratchDir() + "/LoadExecInterpretOnlyOatUpToDate.jar";
|
|
|
|
Copy(GetDexSrc1(), dex_location);
|
|
GenerateOatForTest(dex_location.c_str(), CompilerFilter::kQuicken);
|
|
|
|
ScopedNonWritable scoped_non_writable(dex_location);
|
|
ASSERT_TRUE(scoped_non_writable.IsSuccessful());
|
|
|
|
// Load the oat using an oat file assistant.
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, true);
|
|
|
|
std::unique_ptr<OatFile> oat_file = oat_file_assistant.GetBestOatFile();
|
|
ASSERT_TRUE(oat_file.get() != nullptr);
|
|
EXPECT_TRUE(oat_file->IsExecutable());
|
|
std::vector<std::unique_ptr<const DexFile>> dex_files;
|
|
dex_files = oat_file_assistant.LoadDexFiles(*oat_file, dex_location.c_str());
|
|
EXPECT_EQ(1u, dex_files.size());
|
|
}
|
|
|
|
// Case: We have a DEX file and up-to-date OAT file for it.
|
|
// Expect: Loading non-executable should load the oat non-executable.
|
|
TEST_F(OatFileAssistantTest, LoadNoExecOatUpToDate) {
|
|
if (IsExecutedAsRoot()) {
|
|
// We cannot simulate non writable locations when executed as root: b/38000545.
|
|
LOG(ERROR) << "Test skipped because it's running as root";
|
|
return;
|
|
}
|
|
|
|
std::string dex_location = GetScratchDir() + "/LoadNoExecOatUpToDate.jar";
|
|
|
|
Copy(GetDexSrc1(), dex_location);
|
|
|
|
ScopedNonWritable scoped_non_writable(dex_location);
|
|
ASSERT_TRUE(scoped_non_writable.IsSuccessful());
|
|
|
|
GenerateOatForTest(dex_location.c_str(), CompilerFilter::kSpeed);
|
|
|
|
// Load the oat using an oat file assistant.
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
|
|
std::unique_ptr<OatFile> oat_file = oat_file_assistant.GetBestOatFile();
|
|
ASSERT_TRUE(oat_file.get() != nullptr);
|
|
EXPECT_FALSE(oat_file->IsExecutable());
|
|
std::vector<std::unique_ptr<const DexFile>> dex_files;
|
|
dex_files = oat_file_assistant.LoadDexFiles(*oat_file, dex_location.c_str());
|
|
EXPECT_EQ(1u, dex_files.size());
|
|
}
|
|
|
|
// Case: We don't have a DEX file and can't write the oat file.
|
|
// Expect: We should fail to generate the oat file without crashing.
|
|
TEST_F(OatFileAssistantTest, GenNoDex) {
|
|
if (IsExecutedAsRoot()) {
|
|
// We cannot simulate non writable locations when executed as root: b/38000545.
|
|
LOG(ERROR) << "Test skipped because it's running as root";
|
|
return;
|
|
}
|
|
|
|
std::string dex_location = GetScratchDir() + "/GenNoDex.jar";
|
|
|
|
ScopedNonWritable scoped_non_writable(dex_location);
|
|
ASSERT_TRUE(scoped_non_writable.IsSuccessful());
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, true);
|
|
std::string error_msg;
|
|
Runtime::Current()->AddCompilerOption("--compiler-filter=speed");
|
|
// We should get kUpdateSucceeded from MakeUpToDate since there's nothing
|
|
// that can be done in this situation.
|
|
ASSERT_EQ(OatFileAssistant::kUpdateSucceeded,
|
|
oat_file_assistant.MakeUpToDate(false, kSpecialSharedLibraryContext, &error_msg));
|
|
|
|
// Verify it didn't create an oat in the default location (dalvik-cache).
|
|
OatFileAssistant ofm(dex_location.c_str(), kRuntimeISA, false);
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, ofm.OatFileStatus());
|
|
// Verify it didn't create the odex file in the default location (../oat/isa/...odex)
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, ofm.OdexFileStatus());
|
|
}
|
|
|
|
// Turn an absolute path into a path relative to the current working
|
|
// directory.
|
|
static std::string MakePathRelative(const std::string& target) {
|
|
char buf[MAXPATHLEN];
|
|
std::string cwd = getcwd(buf, MAXPATHLEN);
|
|
|
|
// Split the target and cwd paths into components.
|
|
std::vector<std::string> target_path;
|
|
std::vector<std::string> cwd_path;
|
|
Split(target, '/', &target_path);
|
|
Split(cwd, '/', &cwd_path);
|
|
|
|
// Reverse the path components, so we can use pop_back().
|
|
std::reverse(target_path.begin(), target_path.end());
|
|
std::reverse(cwd_path.begin(), cwd_path.end());
|
|
|
|
// Drop the common prefix of the paths. Because we reversed the path
|
|
// components, this becomes the common suffix of target_path and cwd_path.
|
|
while (!target_path.empty() && !cwd_path.empty()
|
|
&& target_path.back() == cwd_path.back()) {
|
|
target_path.pop_back();
|
|
cwd_path.pop_back();
|
|
}
|
|
|
|
// For each element of the remaining cwd_path, add '..' to the beginning
|
|
// of the target path. Because we reversed the path components, we add to
|
|
// the end of target_path.
|
|
for (unsigned int i = 0; i < cwd_path.size(); i++) {
|
|
target_path.push_back("..");
|
|
}
|
|
|
|
// Reverse again to get the right path order, and join to get the result.
|
|
std::reverse(target_path.begin(), target_path.end());
|
|
return android::base::Join(target_path, '/');
|
|
}
|
|
|
|
// Case: Non-absolute path to Dex location.
|
|
// Expect: Not sure, but it shouldn't crash.
|
|
TEST_F(OatFileAssistantTest, NonAbsoluteDexLocation) {
|
|
std::string abs_dex_location = GetScratchDir() + "/NonAbsoluteDexLocation.jar";
|
|
Copy(GetDexSrc1(), abs_dex_location);
|
|
|
|
std::string dex_location = MakePathRelative(abs_dex_location);
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, true);
|
|
|
|
EXPECT_FALSE(oat_file_assistant.IsInBootClassPath());
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatFromScratch,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OdexFileStatus());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OatFileStatus());
|
|
}
|
|
|
|
// Case: Very short, non-existent Dex location.
|
|
// Expect: kNoDexOptNeeded.
|
|
TEST_F(OatFileAssistantTest, ShortDexLocation) {
|
|
std::string dex_location = "/xx";
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, true);
|
|
|
|
EXPECT_FALSE(oat_file_assistant.IsInBootClassPath());
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OdexFileStatus());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OatFileStatus());
|
|
EXPECT_FALSE(oat_file_assistant.HasOriginalDexFiles());
|
|
|
|
// Trying to make it up to date should have no effect.
|
|
std::string error_msg;
|
|
Runtime::Current()->AddCompilerOption("--compiler-filter=speed");
|
|
EXPECT_EQ(OatFileAssistant::kUpdateSucceeded,
|
|
oat_file_assistant.MakeUpToDate(false, kSpecialSharedLibraryContext, &error_msg));
|
|
EXPECT_TRUE(error_msg.empty());
|
|
}
|
|
|
|
// Case: Non-standard extension for dex file.
|
|
// Expect: The status is kDex2OatNeeded.
|
|
TEST_F(OatFileAssistantTest, LongDexExtension) {
|
|
std::string dex_location = GetScratchDir() + "/LongDexExtension.jarx";
|
|
Copy(GetDexSrc1(), dex_location);
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatFromScratch,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
|
|
EXPECT_FALSE(oat_file_assistant.IsInBootClassPath());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OdexFileStatus());
|
|
EXPECT_EQ(OatFileAssistant::kOatCannotOpen, oat_file_assistant.OatFileStatus());
|
|
}
|
|
|
|
// A task to generate a dex location. Used by the RaceToGenerate test.
|
|
class RaceGenerateTask : public Task {
|
|
public:
|
|
explicit RaceGenerateTask(const std::string& dex_location, const std::string& oat_location)
|
|
: dex_location_(dex_location), oat_location_(oat_location), loaded_oat_file_(nullptr)
|
|
{}
|
|
|
|
void Run(Thread* self ATTRIBUTE_UNUSED) {
|
|
// Load the dex files, and save a pointer to the loaded oat file, so that
|
|
// we can verify only one oat file was loaded for the dex location.
|
|
std::vector<std::unique_ptr<const DexFile>> dex_files;
|
|
std::vector<std::string> error_msgs;
|
|
const OatFile* oat_file = nullptr;
|
|
dex_files = Runtime::Current()->GetOatFileManager().OpenDexFilesFromOat(
|
|
dex_location_.c_str(),
|
|
Runtime::Current()->GetSystemClassLoader(),
|
|
/*dex_elements*/nullptr,
|
|
&oat_file,
|
|
&error_msgs);
|
|
CHECK(!dex_files.empty()) << android::base::Join(error_msgs, '\n');
|
|
CHECK(dex_files[0]->GetOatDexFile() != nullptr) << dex_files[0]->GetLocation();
|
|
loaded_oat_file_ = dex_files[0]->GetOatDexFile()->GetOatFile();
|
|
CHECK_EQ(loaded_oat_file_, oat_file);
|
|
}
|
|
|
|
const OatFile* GetLoadedOatFile() const {
|
|
return loaded_oat_file_;
|
|
}
|
|
|
|
private:
|
|
std::string dex_location_;
|
|
std::string oat_location_;
|
|
const OatFile* loaded_oat_file_;
|
|
};
|
|
|
|
// Test the case where multiple processes race to generate an oat file.
|
|
// This simulates multiple processes using multiple threads.
|
|
//
|
|
// We want unique Oat files to be loaded even when there is a race to load.
|
|
// TODO: The test case no longer tests locking the way it was intended since we now get multiple
|
|
// copies of the same Oat files mapped at different locations.
|
|
TEST_F(OatFileAssistantTest, RaceToGenerate) {
|
|
std::string dex_location = GetScratchDir() + "/RaceToGenerate.jar";
|
|
std::string oat_location = GetOdexDir() + "/RaceToGenerate.oat";
|
|
|
|
// Start the runtime to initialize the system's class loader.
|
|
Thread::Current()->TransitionFromSuspendedToRunnable();
|
|
runtime_->Start();
|
|
|
|
// We use the lib core dex file, because it's large, and hopefully should
|
|
// take a while to generate.
|
|
Copy(GetLibCoreDexFileNames()[0], dex_location);
|
|
|
|
const int kNumThreads = 32;
|
|
Thread* self = Thread::Current();
|
|
ThreadPool thread_pool("Oat file assistant test thread pool", kNumThreads);
|
|
std::vector<std::unique_ptr<RaceGenerateTask>> tasks;
|
|
for (int i = 0; i < kNumThreads; i++) {
|
|
std::unique_ptr<RaceGenerateTask> task(new RaceGenerateTask(dex_location, oat_location));
|
|
thread_pool.AddTask(self, task.get());
|
|
tasks.push_back(std::move(task));
|
|
}
|
|
thread_pool.StartWorkers(self);
|
|
thread_pool.Wait(self, true, false);
|
|
|
|
// Verify every task got a unique oat file.
|
|
std::set<const OatFile*> oat_files;
|
|
for (auto& task : tasks) {
|
|
const OatFile* oat_file = task->GetLoadedOatFile();
|
|
EXPECT_TRUE(oat_files.find(oat_file) == oat_files.end());
|
|
oat_files.insert(oat_file);
|
|
}
|
|
}
|
|
|
|
// Case: We have a DEX file and an ODEX file, no OAT file, and dex2oat is
|
|
// disabled.
|
|
// Expect: We should load the odex file non-executable.
|
|
TEST_F(OatFileAssistantNoDex2OatTest, LoadDexOdexNoOat) {
|
|
std::string dex_location = GetScratchDir() + "/LoadDexOdexNoOat.jar";
|
|
std::string odex_location = GetOdexDir() + "/LoadDexOdexNoOat.odex";
|
|
|
|
// Create the dex and odex files
|
|
Copy(GetDexSrc1(), dex_location);
|
|
GenerateOdexForTest(dex_location, odex_location, CompilerFilter::kSpeed);
|
|
|
|
// Load the oat using an executable oat file assistant.
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, true);
|
|
|
|
std::unique_ptr<OatFile> oat_file = oat_file_assistant.GetBestOatFile();
|
|
ASSERT_TRUE(oat_file.get() != nullptr);
|
|
EXPECT_FALSE(oat_file->IsExecutable());
|
|
std::vector<std::unique_ptr<const DexFile>> dex_files;
|
|
dex_files = oat_file_assistant.LoadDexFiles(*oat_file, dex_location.c_str());
|
|
EXPECT_EQ(1u, dex_files.size());
|
|
}
|
|
|
|
// Case: We have a MultiDEX file and an ODEX file, no OAT file, and dex2oat is
|
|
// disabled.
|
|
// Expect: We should load the odex file non-executable.
|
|
TEST_F(OatFileAssistantNoDex2OatTest, LoadMultiDexOdexNoOat) {
|
|
std::string dex_location = GetScratchDir() + "/LoadMultiDexOdexNoOat.jar";
|
|
std::string odex_location = GetOdexDir() + "/LoadMultiDexOdexNoOat.odex";
|
|
|
|
// Create the dex and odex files
|
|
Copy(GetMultiDexSrc1(), dex_location);
|
|
GenerateOdexForTest(dex_location, odex_location, CompilerFilter::kSpeed);
|
|
|
|
// Load the oat using an executable oat file assistant.
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, true);
|
|
|
|
std::unique_ptr<OatFile> oat_file = oat_file_assistant.GetBestOatFile();
|
|
ASSERT_TRUE(oat_file.get() != nullptr);
|
|
EXPECT_FALSE(oat_file->IsExecutable());
|
|
std::vector<std::unique_ptr<const DexFile>> dex_files;
|
|
dex_files = oat_file_assistant.LoadDexFiles(*oat_file, dex_location.c_str());
|
|
EXPECT_EQ(2u, dex_files.size());
|
|
}
|
|
|
|
TEST_F(OatFileAssistantTest, RuntimeCompilerFilterOptionUsed) {
|
|
std::string dex_location = GetScratchDir() + "/RuntimeCompilerFilterOptionUsed.jar";
|
|
Copy(GetDexSrc1(), dex_location);
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
|
|
std::string error_msg;
|
|
Runtime::Current()->AddCompilerOption("--compiler-filter=quicken");
|
|
EXPECT_EQ(OatFileAssistant::kUpdateSucceeded,
|
|
oat_file_assistant.MakeUpToDate(false, kSpecialSharedLibraryContext, &error_msg)) <<
|
|
error_msg;
|
|
EXPECT_EQ(-OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kQuicken));
|
|
EXPECT_EQ(-OatFileAssistant::kDex2OatForFilter,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
|
|
Runtime::Current()->AddCompilerOption("--compiler-filter=speed");
|
|
EXPECT_EQ(OatFileAssistant::kUpdateSucceeded,
|
|
oat_file_assistant.MakeUpToDate(false, kSpecialSharedLibraryContext, &error_msg))
|
|
<< error_msg;
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kQuicken));
|
|
EXPECT_EQ(OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(CompilerFilter::kSpeed));
|
|
|
|
Runtime::Current()->AddCompilerOption("--compiler-filter=bogus");
|
|
EXPECT_EQ(OatFileAssistant::kUpdateNotAttempted,
|
|
oat_file_assistant.MakeUpToDate(false, kSpecialSharedLibraryContext, &error_msg));
|
|
}
|
|
|
|
TEST(OatFileAssistantUtilsTest, DexLocationToOdexFilename) {
|
|
std::string error_msg;
|
|
std::string odex_file;
|
|
|
|
EXPECT_TRUE(OatFileAssistant::DexLocationToOdexFilename(
|
|
"/foo/bar/baz.jar", kArm, &odex_file, &error_msg)) << error_msg;
|
|
EXPECT_EQ("/foo/bar/oat/arm/baz.odex", odex_file);
|
|
|
|
EXPECT_TRUE(OatFileAssistant::DexLocationToOdexFilename(
|
|
"/foo/bar/baz.funnyext", kArm, &odex_file, &error_msg)) << error_msg;
|
|
EXPECT_EQ("/foo/bar/oat/arm/baz.odex", odex_file);
|
|
|
|
EXPECT_FALSE(OatFileAssistant::DexLocationToOdexFilename(
|
|
"nopath.jar", kArm, &odex_file, &error_msg));
|
|
EXPECT_FALSE(OatFileAssistant::DexLocationToOdexFilename(
|
|
"/foo/bar/baz_noext", kArm, &odex_file, &error_msg));
|
|
}
|
|
|
|
// Verify the dexopt status values from dalvik.system.DexFile
|
|
// match the OatFileAssistant::DexOptStatus values.
|
|
TEST_F(OatFileAssistantTest, DexOptStatusValues) {
|
|
std::pair<OatFileAssistant::DexOptNeeded, const char*> mapping[] = {
|
|
{OatFileAssistant::kNoDexOptNeeded, "NO_DEXOPT_NEEDED"},
|
|
{OatFileAssistant::kDex2OatFromScratch, "DEX2OAT_FROM_SCRATCH"},
|
|
{OatFileAssistant::kDex2OatForBootImage, "DEX2OAT_FOR_BOOT_IMAGE"},
|
|
{OatFileAssistant::kDex2OatForFilter, "DEX2OAT_FOR_FILTER"},
|
|
{OatFileAssistant::kDex2OatForRelocation, "DEX2OAT_FOR_RELOCATION"},
|
|
};
|
|
|
|
ScopedObjectAccess soa(Thread::Current());
|
|
StackHandleScope<1> hs(soa.Self());
|
|
ClassLinker* linker = Runtime::Current()->GetClassLinker();
|
|
Handle<mirror::Class> dexfile(
|
|
hs.NewHandle(linker->FindSystemClass(soa.Self(), "Ldalvik/system/DexFile;")));
|
|
ASSERT_FALSE(dexfile == nullptr);
|
|
linker->EnsureInitialized(soa.Self(), dexfile, true, true);
|
|
|
|
for (std::pair<OatFileAssistant::DexOptNeeded, const char*> field : mapping) {
|
|
ArtField* art_field = mirror::Class::FindStaticField(
|
|
soa.Self(), dexfile.Get(), field.second, "I");
|
|
ASSERT_FALSE(art_field == nullptr);
|
|
EXPECT_EQ(art_field->GetTypeAsPrimitiveType(), Primitive::kPrimInt);
|
|
EXPECT_EQ(field.first, art_field->GetInt(dexfile.Get()));
|
|
}
|
|
}
|
|
|
|
// Verify that when no compiler filter is passed the default one from OatFileAssistant is used.
|
|
TEST_F(OatFileAssistantTest, DefaultMakeUpToDateFilter) {
|
|
std::string dex_location = GetScratchDir() + "/TestDex.jar";
|
|
Copy(GetDexSrc1(), dex_location);
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
|
|
const CompilerFilter::Filter default_filter =
|
|
OatFileAssistant::kDefaultCompilerFilterForDexLoading;
|
|
std::string error_msg;
|
|
EXPECT_EQ(OatFileAssistant::kUpdateSucceeded,
|
|
oat_file_assistant.MakeUpToDate(false, kSpecialSharedLibraryContext, &error_msg)) <<
|
|
error_msg;
|
|
EXPECT_EQ(-OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(default_filter));
|
|
std::unique_ptr<OatFile> oat_file = oat_file_assistant.GetBestOatFile();
|
|
EXPECT_NE(nullptr, oat_file.get());
|
|
EXPECT_EQ(default_filter, oat_file->GetCompilerFilter());
|
|
}
|
|
|
|
TEST_F(OatFileAssistantTest, MakeUpToDateWithSpecialSharedLibrary) {
|
|
std::string dex_location = GetScratchDir() + "/TestDex.jar";
|
|
Copy(GetDexSrc1(), dex_location);
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
|
|
const CompilerFilter::Filter default_filter =
|
|
OatFileAssistant::kDefaultCompilerFilterForDexLoading;
|
|
std::string error_msg;
|
|
int status = oat_file_assistant.MakeUpToDate(false, kSpecialSharedLibraryContext, &error_msg);
|
|
EXPECT_EQ(OatFileAssistant::kUpdateSucceeded, status) << error_msg;
|
|
EXPECT_EQ(-OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(default_filter));
|
|
std::unique_ptr<OatFile> oat_file = oat_file_assistant.GetBestOatFile();
|
|
EXPECT_NE(nullptr, oat_file.get());
|
|
EXPECT_EQ(kSpecialSharedLibrary,
|
|
oat_file->GetOatHeader().GetStoreValueByKey(OatHeader::kClassPathKey));
|
|
}
|
|
|
|
TEST_F(OatFileAssistantTest, MakeUpToDateWithContext) {
|
|
std::string dex_location = GetScratchDir() + "/TestDex.jar";
|
|
std::string context_location = GetScratchDir() + "/ContextDex.jar";
|
|
Copy(GetDexSrc1(), dex_location);
|
|
Copy(GetDexSrc2(), context_location);
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
|
|
const CompilerFilter::Filter default_filter =
|
|
OatFileAssistant::kDefaultCompilerFilterForDexLoading;
|
|
std::string error_msg;
|
|
std::string context_str = "PCL[" + context_location + "]";
|
|
std::unique_ptr<ClassLoaderContext> context = ClassLoaderContext::Create(context_str);
|
|
ASSERT_TRUE(context != nullptr);
|
|
ASSERT_TRUE(context->OpenDexFiles(kRuntimeISA, ""));
|
|
|
|
int status = oat_file_assistant.MakeUpToDate(false, context.get(), &error_msg);
|
|
EXPECT_EQ(OatFileAssistant::kUpdateSucceeded, status) << error_msg;
|
|
EXPECT_EQ(-OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(default_filter, false, false, context.get()));
|
|
|
|
std::unique_ptr<OatFile> oat_file = oat_file_assistant.GetBestOatFile();
|
|
EXPECT_NE(nullptr, oat_file.get());
|
|
EXPECT_EQ(context->EncodeContextForOatFile(""),
|
|
oat_file->GetOatHeader().GetStoreValueByKey(OatHeader::kClassPathKey));
|
|
}
|
|
|
|
TEST_F(OatFileAssistantTest, GetDexOptNeededWithOutOfDateContext) {
|
|
std::string dex_location = GetScratchDir() + "/TestDex.jar";
|
|
std::string context_location = GetScratchDir() + "/ContextDex.jar";
|
|
Copy(GetDexSrc1(), dex_location);
|
|
Copy(GetDexSrc2(), context_location);
|
|
|
|
OatFileAssistant oat_file_assistant(dex_location.c_str(), kRuntimeISA, false);
|
|
|
|
const CompilerFilter::Filter default_filter =
|
|
OatFileAssistant::kDefaultCompilerFilterForDexLoading;
|
|
std::string error_msg;
|
|
std::string context_str = "PCL[" + context_location + "]";
|
|
std::unique_ptr<ClassLoaderContext> context = ClassLoaderContext::Create(context_str);
|
|
ASSERT_TRUE(context != nullptr);
|
|
ASSERT_TRUE(context->OpenDexFiles(kRuntimeISA, ""));
|
|
|
|
int status = oat_file_assistant.MakeUpToDate(false, context.get(), &error_msg);
|
|
EXPECT_EQ(OatFileAssistant::kUpdateSucceeded, status) << error_msg;
|
|
EXPECT_EQ(-OatFileAssistant::kNoDexOptNeeded,
|
|
oat_file_assistant.GetDexOptNeeded(default_filter, false, false, context.get()));
|
|
|
|
// Update the context by overriding the jar file.
|
|
Copy(GetMultiDexSrc2(), context_location);
|
|
std::unique_ptr<ClassLoaderContext> updated_context = ClassLoaderContext::Create(context_str);
|
|
ASSERT_TRUE(updated_context != nullptr);
|
|
// DexOptNeeded should advise compilation from scratch.
|
|
EXPECT_EQ(OatFileAssistant::kDex2OatFromScratch,
|
|
oat_file_assistant.GetDexOptNeeded(
|
|
default_filter, false, false, updated_context.get()));
|
|
}
|
|
|
|
// TODO: More Tests:
|
|
// * Test class linker falls back to unquickened dex for DexNoOat
|
|
// * Test class linker falls back to unquickened dex for MultiDexNoOat
|
|
// * Test using secondary isa
|
|
// * Test for status of oat while oat is being generated (how?)
|
|
// * Test case where 32 and 64 bit boot class paths differ,
|
|
// and we ask IsInBootClassPath for a class in exactly one of the 32 or
|
|
// 64 bit boot class paths.
|
|
// * Test unexpected scenarios (?):
|
|
// - Dex is stripped, don't have odex.
|
|
// - Oat file corrupted after status check, before reload unexecutable
|
|
// because it's unrelocated and no dex2oat
|
|
} // namespace art
|